Wrap types in default module in $default namespace and re-export them at top level
#888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em at top level Fixes references to default types within other modules containing types with the same type name
scotttrinh
reviewed
Mar 5, 2024
Comment on lines
201
to
207
| if (module.isRoot && module.name === "default") { | ||
| for (const [typeName, typeRef] of module.types) { | ||
| plainTypesCode.writeln([`import ${typeName} = ${typeRef};`]); | ||
| } | ||
| plainTypesCode.writeln([ | ||
| `export {${[...module.types.keys()].join(", ")}};`, | ||
| ]); |
There was a problem hiding this comment.
Seems like this is already covered by the existing tests in interfaces.test.ts, but do you think it'd be easy to write a quick check for the pathological case we're fixing here?
There was a problem hiding this comment.
Added some tests and fixes some bugs.
scotttrinh
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #882