Refactor codec to TS generation for fine grained customization #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$.parseQuery
->Client.parse
. This feels better as it doesn't have to assume as much regarding client pool, options, or session.Perhaps a name like
$parse
orparse$
would be desired though?$.util.parseCardinality
as a standard way to convert from the protocol number cardinality to the string enum used by the query builder.Happy to move it where ever.
parse
returns a string enumCardinality
now rather than the protocol one.This was the only spot the protocol cardinality leaked into type gen and it felt inconsistent in my (advanced) usage.
And then the big refactor of
walkCodec
, nowgenerateTSTypeFromCodec
.I broke down the logic for how to generate each codec into their own functions.
Now
generateTSTypeFromCodec
just orchestrates calling these methods (optionally customized via input map).