Add Auth to Remix create & small fixes #891
Conversation
Update Remix and Sveltekit index pages with builtin-ui signin.
| "eslint-plugin-import": "^2.28.1", | ||
| "eslint-plugin-jsx-a11y": "^6.7.1", | ||
| "eslint-plugin-react": "^7.33.2", | ||
| "eslint-plugin-react-hooks": "^4.6.0", | ||
| typescript: "^5.1.6", |
There was a problem hiding this comment.
Didn't check the other new dependencies, but is there a reason why we're referring to an older version of typescript here?
There was a problem hiding this comment.
this is also from the newest remix create template, they use ts "^5.1.6", or do u think I should use "*" here?
There was a problem hiding this comment.
not sure if sth can break in the future if we use "*" in package.json
There was a problem hiding this comment.
Yeah, that's a good question. Let's just follow their version ranges for now.
| }, | ||
| }, | ||
|
|
||
| // TypeScript | ||
| // Typescript |
There was a problem hiding this comment.
TypeScript is correct. (see https://www.typescriptlang.org/)
There was a problem hiding this comment.
ah ok, this is changed because newest Remix create will create this, so I copied their newest .eslintrc.cjs
There was a problem hiding this comment.
😅 Fine to keep it then, not a big deal.
yarn run createinstead ofyarn createwhen running locally because yarn create is used for creating new projects from create starter kits, it will not run our create scripts but it expects create-starter-kit as an argument.Maybe I used something wrong, if this works on your side @jaclarke @scotttrinh I can revert this changes.
Added auth files to Remix template since it was missing it.
Updated Remix and Sveltekit index pages to show link to builtin UI if enabled.