Adjust parentheses on QB cast rendering to fix pathing off of it #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
reviewed
Mar 25, 2024
CarsonF
force-pushed
the
bugfix/object-cast-parentheses
branch
2 times, most recently
from
be77527
to
e3f640a
Compare
CarsonF
force-pushed
the
bugfix/object-cast-parentheses
branch
from
1e7db39
to
bed1fbd
Compare
CarsonF
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #917.
I'm not sure when the inner exp would need to be wrapped in parentheses before casting, but I removed that.
Now wrapping the whole expression.
Also removing the parentheses wrapping for multiple cast siblings.