Add auth_successful_logins_total

edgedb · Mar 8, 2024 · 0b3057e · 0b3057e
1 parent b34ea84
commit 0b3057e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/docs/reference/http.rst b/docs/reference/http.rst
@@ -174,6 +174,9 @@ Auth Extension
 ``auth_providers``
   **Histogram.** Number of Auth providers configured.
 
+``auth_successful_logins_total``
+  **Counter.** Number of successful logins in the Auth extension.
+
 Errors
 ^^^^^^
 

diff --git a/edb/server/metrics.py b/edb/server/metrics.py
@@ -193,3 +193,9 @@
     'Number of Auth providers configured.',
     labels=('tenant', 'branch'),
 )
+
+auth_successful_logins = registry.new_labeled_counter(
+    "auth_successful_logins_total",
+    "Number of successful logins in the Auth extension.",
+    labels=("tenant",),
+)
diff --git a/edb/server/protocol/auth_ext/http.py b/edb/server/protocol/auth_ext/http.py
@@ -38,7 +38,7 @@
 from edb.common import debug
 from edb.common import markup
 from edb.ir import statypes
-from edb.server import tenant as edbtenant
+from edb.server import tenant as edbtenant, metrics
 from edb.server.config.types import CompositeConfigType
 
 from . import (
@@ -1660,6 +1660,9 @@ def _make_session_token(self, identity_id: str) -> str:
             claims=claims,
         )
         session_token.make_signed_token(signing_key)
+        metrics.auth_successful_logins.inc(
+            1.0, self.tenant.get_instance_name()
+        )
         return session_token.serialize()
 
     def _get_from_claims(self, state: str, key: str) -> str: