Return JSON for magic link register #6974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
force-pushed
the
magic-link-register-failure
branch
2 times, most recently
from
74cf12e
to
5c2179f
Compare
scotttrinh
force-pushed
the
magic-link-register-failure
branch
from
d450fac
to
5c2179f
Compare
jaclarke
approved these changes
Mar 5, 2024
If the request specifies `Accept: application/json`, then even failures should return JSON for the register request. `redirect_on_failure` is still used to redirect in the case there is an issue when the user follows the link since that's a GET request by a user agent like a browser.
scotttrinh
force-pushed
the
magic-link-register-failure
branch
from
5c2179f
to
794d31e
Compare
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request specifies
Accept: application/json, then even failures should return JSON for the register request.redirect_on_failureis still used to redirect in the case there is an issue when the user follows the link since that's a GET request by a user agent like a browser.