Explicitly pass WebAuthn credential properties #6975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
changed the title
jaclarke
reviewed
Mar 5, 2024
| ...props.assertion, | ||
| type: props.assertion.type, | ||
| id: props.assertion.id, | ||
| authenticatorAttachments: props.assertion.authenticatorAttachment, |
There was a problem hiding this comment.
Should this be authenticatorAttachment (no 's')?
There was a problem hiding this comment.
Good eye. It's optional so I guess it worked in my testing just accidentally 🙈 . Getting pretty close to creating a mock authenticator so we can actually test these end-to-end...
jaclarke
approved these changes
Mar 5, 2024
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
msullivan
pushed a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was working before due to some idiosyncratic behavior of Bitwarden's passkey implementation, but when I tried this with the built-in Chrome passkey functionality, I was getting errors about missing properties.