Ensure WebAuthn redirect matches expected shape #6987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaclarke
approved these changes
Mar 5, 2024
scotttrinh
force-pushed
the
verification-redirect-fix
branch
from
5653229
to
8b90aa7
Compare
scotttrinh
force-pushed
the
conform-webauthn-redirect
branch
from
fbf7b3d
to
380e099
Compare
scotttrinh
force-pushed
the
verification-redirect-fix
branch
2 times, most recently
from
f82111f
to
a87e21e
Compare
scotttrinh
force-pushed
the
conform-webauthn-redirect
branch
from
380e099
to
dd5ee2d
Compare
In our framework helpers, we expect that the UI callback is either called with a `code` search parameter, or a `verification_email_sent_at` parameter, otherwise it treats the response as an error.
scotttrinh
force-pushed
the
conform-webauthn-redirect
branch
from
dd5ee2d
to
5af4198
Compare
msullivan
pushed a commit
that referenced
this pull request
Mar 8, 2024
In our framework helpers, we expect that the UI callback is either called with a `code` search parameter, or a `verification_email_sent_at` parameter, otherwise it treats the response as an error.
msullivan
pushed a commit
that referenced
this pull request
Mar 8, 2024
In our framework helpers, we expect that the UI callback is either called with a `code` search parameter, or a `verification_email_sent_at` parameter, otherwise it treats the response as an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our framework helpers, we expect that the UI callback is either called with a
codesearch parameter, or averification_email_sent_atparameter, otherwise it treats the response as an error.