Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "branch" to database does not exist error message #7022

Merged
merged 1 commit into from Mar 8, 2024
Merged

Add "branch" to database does not exist error message #7022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion edb/server/dbview/dbview.pyx
View file
Open in desktop
Expand Up @@ -1303,7 +1303,7 @@ cdef class DatabaseIndex:
return self._dbs[dbname]
except KeyError:
raise errors.UnknownDatabaseError(
f'database {dbname!r} does not exist')
f'database branch {dbname!r} does not exist')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping database here seems debatable, but I don't have a strong argument in favor of either direction, so lgtm!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done similar in a lot of places in the server


def maybe_get_db(self, dbname):
return self._dbs.get(dbname)
Expand Down