Add optional PKCE challenge in email verification #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the email verification endpoint assumes that if you only provide the email address, you are not in a PKCE flow, which means the verification ends with a redirect, or no content. However, most of the supporting libraries expect that verification ends with a PKCE code exchange. Adding an optional PKCE challenge to the email verification endpoint allows the client perform the PKCE code exchange even if they only have an email.
1st1
approved these changes
Mar 13, 2024
msullivan
pushed a commit
that referenced
this pull request
Mar 15, 2024
Currently, the email verification endpoint assumes that if you only provide the email address, you are not in a PKCE flow, which means the verification ends with a redirect, or no content. However, most of the supporting libraries expect that verification ends with a PKCE code exchange. Adding an optional PKCE challenge to the email verification endpoint allows the client perform the PKCE code exchange even if they only have an email.
msullivan
pushed a commit
that referenced
this pull request
Mar 15, 2024
Currently, the email verification endpoint assumes that if you only provide the email address, you are not in a PKCE flow, which means the verification ends with a redirect, or no content. However, most of the supporting libraries expect that verification ends with a PKCE code exchange. Adding an optional PKCE challenge to the email verification endpoint allows the client perform the PKCE code exchange even if they only have an email.
aljazerzen
pushed a commit
that referenced
this pull request
Mar 19, 2024
Currently, the email verification endpoint assumes that if you only provide the email address, you are not in a PKCE flow, which means the verification ends with a redirect, or no content. However, most of the supporting libraries expect that verification ends with a PKCE code exchange. Adding an optional PKCE challenge to the email verification endpoint allows the client perform the PKCE code exchange even if they only have an email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the email verification endpoint assumes that if you only provide the email address, you are not in a PKCE flow, which means the verification ends with a redirect, or no content. However, most of the supporting libraries expect that verification ends with a PKCE code exchange. Adding an optional PKCE challenge to the email verification endpoint allows the client perform the PKCE code exchange even if they only have an email.