Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore cheatsheets to side navigation #7072

Merged
merged 2 commits into from Mar 18, 2024
Merged

Conversation

raddevon
Copy link
Contributor

@raddevon raddevon commented Mar 18, 2024

Discovered this problem this morning. Position of the TOC in the file now determines what gets rendered in the navigation sidebar, which resulted in the individual cheatsheet links not being rendered there. This was further complicated by the fact that the booleans cheatsheet link at Cheatsheets > Overview was set to the incorrect target, making that cheatsheet difficult to access except via search.

so that the individual cheatsheets appear in the side navigation
Copy link
Contributor

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about the docs implementation here, so I'd treat my approval as a bit of a rubber stamp just saying I read through the code and it seems reasonable, but can't speak to the underlying issue of the toctree placement.

@raddevon raddevon merged commit 29e32bd into master Mar 18, 2024
25 checks passed
@raddevon raddevon deleted the doc-fix-cheatsheets-toc branch March 18, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants