Set "Connection: close" for non-keep-alive requests #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the HTTP 1.1 Spec: > An HTTP/1.1 server MAY assume that a HTTP/1.1 client intends to > maintain a persistent connection unless a Connection header including > the connection-token "close" was sent in the request. If the server > chooses to close the connection immediately after sending the > response, it SHOULD send a Connection header including the > connection-token close. https://www.rfc-editor.org/rfc/rfc2616#section-8.1.2.1 The Node.js `Request` module depends on getting the header `Connection: close` to properly sequence socket messages, otherwise it throws a "socket hang up" error. This issue was found due to Remix having a custom implementation of `fetch` that use's Node.js's `Request` module, which has different behavior than the native Node.js `fetch` global.
scotttrinh
force-pushed
the
set-response-connection-close
branch
from
36e1524
to
43952a6
Compare
1st1
approved these changes
Mar 20, 2024
vpetrovykh
pushed a commit
that referenced
this pull request
Mar 27, 2024
According to the HTTP 1.1 Spec: > An HTTP/1.1 server MAY assume that a HTTP/1.1 client intends to > maintain a persistent connection unless a Connection header including > the connection-token "close" was sent in the request. If the server > chooses to close the connection immediately after sending the > response, it SHOULD send a Connection header including the > connection-token close. https://www.rfc-editor.org/rfc/rfc2616#section-8.1.2.1 The Node.js `Request` module depends on getting the header `Connection: close` to properly sequence socket messages, otherwise it throws a "socket hang up" error. This issue was found due to Remix having a custom implementation of `fetch` that use's Node.js's `Request` module, which has different behavior than the native Node.js `fetch` global.
vpetrovykh
pushed a commit
that referenced
this pull request
Mar 27, 2024
According to the HTTP 1.1 Spec: > An HTTP/1.1 server MAY assume that a HTTP/1.1 client intends to > maintain a persistent connection unless a Connection header including > the connection-token "close" was sent in the request. If the server > chooses to close the connection immediately after sending the > response, it SHOULD send a Connection header including the > connection-token close. https://www.rfc-editor.org/rfc/rfc2616#section-8.1.2.1 The Node.js `Request` module depends on getting the header `Connection: close` to properly sequence socket messages, otherwise it throws a "socket hang up" error. This issue was found due to Remix having a custom implementation of `fetch` that use's Node.js's `Request` module, which has different behavior than the native Node.js `fetch` global.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See a similar boolean check in the
_handle_responsemethod:edgedb/edb/server/protocol/protocol.pyx
Lines 490 to 491 in 0a7db62
This fixes an issue where we were not setting the
Connection: closeheader unless you specifically setresponse.close_connection, but some HTTP Request implementations (in this casenode.Requestvia Remix's fetch implementation) were treating that as asocket hang uperror (meaning it didn't send theendevent before closing the socket).