Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the changelog for v5.0-beta.2 #7091

Merged
merged 1 commit into from Mar 21, 2024
Merged

Update the changelog for v5.0-beta.2 #7091

merged 1 commit into from Mar 21, 2024

Conversation

vpetrovykh
Copy link
Member

No description provided.

@vpetrovykh vpetrovykh requested review from raddevon and a team March 21, 2024 08:46
Copy link
Contributor

@raddevon raddevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One critical change and one suggestion, and we should be good!

To play with the new features, make sure to specify version 5.0 when
initializing the project as pre-release versions are not considered stable
To play with the new features, make sure to specify version 5.0 when
initializing the project as pre-release versions are not considered stable
and will not be automatically suggested:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and will not be automatically suggested:
and will not be automatically suggested:

Build fails without a line before the code-block.

Comment on lines 175 to 176
We've added ``edgedb branch`` commands to our CLI as well that create, copy,
rename, drop, and rebase EdgeDB branches.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
We've added ``edgedb branch`` commands to our CLI as well that create, copy,
rename, drop, and rebase EdgeDB branches.
We've added :ref:`edgedb branch commands <ref_cli_edgedb_branch>` to our CLI as
well that create, copy, rename, drop, and rebase EdgeDB branches.

In making this suggestion, I've noticed the visual links on the target page are wrong, so I'll fix that in another PR. (I had updated the hidden TOC before merging but not the visible links. 😞)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's that PR to fix the branches command links: #7092

@vpetrovykh vpetrovykh merged commit 6e9657b into master Mar 21, 2024
24 checks passed
@vpetrovykh vpetrovykh deleted the changelog branch March 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants