Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates to the fastapi tutorial #7348

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

beerose
Copy link
Member

@beerose beerose commented May 14, 2024

No description provided.

@edgedb-cla
Copy link

edgedb-cla bot commented May 14, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Comment on lines 32 to 34
``edgedb`` command line tool. For this tutorial, we'll need Python 3.4 or
newer to take advantage of the asynchronous I/O paradigm to communicate with
the database more efficiently. If you want to skip ahead, the completed
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My motivation here was that asyncio was introduced in 3.4 (please correct me if I'm wrong) and there doesn't seem to be any other requirements for >3.10

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a problem with it in principle. Were you able to test the guide on 3.4? I was going to try, but apparently it's challenging to install anything prior to 3.7 on a Mac with Apple Silicon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to revert this change, but added a sentence that you can use a newer version as well.

@beerose beerose requested a review from raddevon May 15, 2024 12:20
Copy link
Contributor

@raddevon raddevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, assuming the guide does work on Python 3.4. (Left another comment addressing that.)

Comment on lines 32 to 34
``edgedb`` command line tool. For this tutorial, we'll need Python 3.4 or
newer to take advantage of the asynchronous I/O paradigm to communicate with
the database more efficiently. If you want to skip ahead, the completed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a problem with it in principle. Were you able to test the guide on 3.4? I was going to try, but apparently it's challenging to install anything prior to 3.7 on a Mac with Apple Silicon.

Copy link
Contributor

@raddevon raddevon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@beerose beerose merged commit db487c6 into master May 16, 2024
24 checks passed
@beerose beerose deleted the fast-api-minor-updates branch May 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants