-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor updates to the fastapi tutorial #7348
Conversation
522201e
to
669b7f6
Compare
``edgedb`` command line tool. For this tutorial, we'll need Python 3.4 or | ||
newer to take advantage of the asynchronous I/O paradigm to communicate with | ||
the database more efficiently. If you want to skip ahead, the completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My motivation here was that asyncio
was introduced in 3.4 (please correct me if I'm wrong) and there doesn't seem to be any other requirements for >3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a problem with it in principle. Were you able to test the guide on 3.4? I was going to try, but apparently it's challenging to install anything prior to 3.7 on a Mac with Apple Silicon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to revert this change, but added a sentence that you can use a newer version as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, assuming the guide does work on Python 3.4. (Left another comment addressing that.)
``edgedb`` command line tool. For this tutorial, we'll need Python 3.4 or | ||
newer to take advantage of the asynchronous I/O paradigm to communicate with | ||
the database more efficiently. If you want to skip ahead, the completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a problem with it in principle. Were you able to test the guide on 3.4? I was going to try, but apparently it's challenging to install anything prior to 3.7 on a Mac with Apple Silicon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
No description provided.