ci: clean up failed miniconstellation e2e tests #3109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
miampf
force-pushed
the
e2e-mini-cleanup
branch
3 times, most recently
from
f6f7677
to
5b05cac
Compare
msanft
reviewed
May 23, 2024
There was a problem hiding this comment.
Diff LGTM, but please also let @daniel-weisse take a look before merging
3u13r
previously requested changes
May 24, 2024
popd on exit just copy everything
miampf
force-pushed
the
e2e-mini-cleanup
branch
2 times, most recently
from
46b1441
to
4f95fcc
Compare
miampf
dismissed
3u13r’s stale review
It was decided to stay with az group delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, if a QEMU/miniconstellation e2e test fails or is cancelled, the created resources won't be cleaned up automatically.
Proposed change(s)
Additional Info
Checklist