Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es full #2234

Closed
wants to merge 2 commits into from
Closed

es full #2234

wants to merge 2 commits into from

Conversation

gitlocalize-app[bot]
Copy link
Contributor

@gautierchomel
Copy link
Member

Succeeded. Had to acces https://gitlocalize.com/repo/9626/es/review

@danielweck
Copy link
Member

Hello @nvdaes , Gautier (@gautierchomel ) revised your contribution to add the missing strings. I just wanted to make sure that you are looped in, just in case you had pending updates, or if you would like to review Gautier's work.

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented May 18, 2024

@gautierchomel , seems that at least some strings added by you aren't consistent with my previous translation, not saved. For example, ?como funciona?, should be: ?Cómo funciona?
Perhaps you used machine translation. My strategy was to use it for the whole file, to complete not translated strings, and later I reviewed it. One of the failures of machine translation was this sentence: ¿Como funciona?, without the diacritic accent.

@gautierchomel
Copy link
Member

@nvdaes I was too quick indeed :) That's an opportunity to test more deeplly the gitlocalize processes.

I'll close this PR without merging to see what happens on gitlocalize.

On your side, can you check if you have 100% translated (with your strings) and open a pull request from gilocalize GUI? (I added you with a moderator role, process is first open the Review request, then from that review request, open the pull request)

@gitlocalize-app gitlocalize-app bot deleted the gitlocalize-29494 branch May 20, 2024 07:13
@nvdaes
Copy link
Sponsor Contributor

nvdaes commented May 20, 2024

I can do it in a few hours, not now. If you cannot wait, do changes yourself and I'll try to test this as soon as possible.

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented May 20, 2024

@gautierchomel , I have 78% translated. I'll translate all strings progressively following your advice.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants