Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SEQUENCE OF ... DEFAULT #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rbalik
Copy link

@rbalik rbalik commented Jan 14, 2022

This fixes issue #123 specifically for OCTET STRING types in the SEQUENCE
It's basically bare minimum for my specific application. Hopefully good enough to merge in, but happy to hear any feedback

@eerimoq
Copy link
Owner

eerimoq commented Jan 14, 2022

Please add a test or two.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #139 (954cba0) into master (e1ecbac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   35.68%   35.68%           
=======================================
  Files           7        7           
  Lines        8446     8446           
=======================================
  Hits         3014     3014           
  Misses       5432     5432           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ecbac...954cba0. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.139% when pulling 954cba0 on rbalik:sequenceofdefault into e1ecbac on eerimoq:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants