Allow usage with Symfony 4 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Author of this bundle is not active anymore. Different package, but same author. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this package is in fact compatible with Symfony 4 already, so it should be enoughto change its requirements in
composer.json. I've created this little PR to add the support. It will be incompatible with Symfony 5 though due to changes inFormTypeExtensionInterface.I've added some jobs to the Travis build to support my claims. Builds on Symfony >=4.2 fail due to deprecations - it succeeds on 4.0 and Symfony is pretty good with keeping backward compatibility. Jobs with hhvm and Docker fail even on current
master(see build of bd2cd20 in my fork or restart the build yourself).Are you still able to merge and release a new version (
3.1.0, I'd suppose), or is this project no longer maintained? Can I help? Thanks 馃檪