fix: convert unhandled rejection to uncaught exception #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set `--unhandled-rejections` to strict, let case fail fast.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
eslint 忽略一下 fixtures 目录 |
|
@killagu ci 修复一下 |
fengmk2
approved these changes
Aug 5, 2023
fengmk2
pushed a commit
that referenced
this pull request
Aug 5, 2023
[skip ci] ## [6.4.2](v6.4.1...v6.4.2) (2023-08-05) ### Bug Fixes * convert unhandled rejection to uncaught exception ([#235](#235)) ([1e25880](1e25880))
|
@killagu chair-bin 使用的还是 5.x https://github.com/eggjs/egg-bin/tree/5.x ，是否也需要 pick 过去？ |
killagu
added a commit
that referenced
this pull request
Aug 7, 2023
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set `--unhandled-rejections` to strict, let case fail fast.
killagu
added a commit
that referenced
this pull request
Aug 7, 2023
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set `--unhandled-rejections` to strict, let case fail fast.
killagu
added a commit
that referenced
this pull request
Aug 7, 2023
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set `--unhandled-rejections` to strict, let case fail fast.
killagu
added a commit
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mocha do not catch unhandled rejection by default. Case will faield until timeout. set
--unhandled-rejectionsto strict, let case fail fast.Checklist
npm testpassesAffected core subsystem(s)
Description of change