Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: worker does not get SIGTERM signal from master when close #111

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

gxkl
Copy link
Contributor

@gxkl gxkl commented Dec 8, 2023

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74cbb35) 92.57% compared to head (566033d) 92.52%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   92.57%   92.52%   -0.05%     
==========================================
  Files          15       15              
  Lines        2020     2021       +1     
  Branches      337      336       -1     
==========================================
  Hits         1870     1870              
- Misses        150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gxkl gxkl requested review from fengmk2 and killagu December 8, 2023 11:03
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit 211c143 into master Dec 8, 2023
12 of 13 checks passed
@fengmk2 fengmk2 deleted the fix/terminate branch December 8, 2023 12:23
@fengmk2 fengmk2 mentioned this pull request Dec 8, 2023
2 tasks
fengmk2 pushed a commit that referenced this pull request Dec 8, 2023
[skip ci]

## [2.2.1](v2.2.0...v2.2.1) (2023-12-08)

### Bug Fixes

* worker does not get SIGTERM signal from master when close ([#111](#111)) ([211c143](211c143))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants