feat: startCluster return master #83
Conversation
| new Master(options).ready(callback); | ||
| const master = new Master(options); | ||
| master.ready(callback); | ||
| return master; |
There was a problem hiding this comment.
就是当初这里设计的时候, 没有把 master 返回, 有啥原因?
There was a problem hiding this comment.
目前遇到一个场景, 就是需要在插件中启动一个 app.
return eggServer.startCluster({
workers: 1,
port: serverPort,
baseDir: __dirname,
});
现在这个地方没有返回, 导致用例结束的时候, master退出的时候, 打印的日志是 error 不太友好.
There was a problem hiding this comment.
恩, 就是返回一个可以主动关闭 master的句柄就行呀. 这样如果在代码启动一个 server, 也可以主动的去关闭, 要不现在没有地方去关.只能等进程退出, 这样也会提示 error 不太友好.
如果主动退出, 就会好很多.
There was a problem hiding this comment.
嗯，之前的做法是启动一个子进程，再杀掉。
这里 exports 还不够，上层框架也要 exports
There was a problem hiding this comment.
恩, 我现在遇到的这个场景是可以了
https://github.com/macacajs/macaca-datahub/blob/master/index.js#L57, 他是这样用的.
那看看这样如果没有啥问题了, 可以先合并了. 我先用着呀.
There was a problem hiding this comment.
嗯，之前的做法是启动一个子进程，再杀掉。
之前他们可能就是没有办法杀掉, 就用了子进程的方式, 结果还采坑了 eggjs/egg-datahub#9 (comment)
There was a problem hiding this comment.
那是他们那边子进程没用对吧 😂
exports 这个我没问题，看贯高。
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
- Coverage 98.57% 98.37% -0.2%
=========================================
Files 8 8
Lines 490 492 +2
=========================================
+ Hits 483 484 +1
- Misses 7 8 +1
Continue to review full report at Codecov.
|
Checklist
npm testpassesAffected core subsystem(s)
Description of change