fix: global plugins in app.config.mongoose.client #39

JayJay1024 · 2019-07-16T15:34:57Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

// {app_root}/config/config.default.js
exports.mongoose = {
  url: 'mongodb://127.0.0.1/example',
  options: {},
  // mongoose global plugins, expected a function or an array of function and options
  plugins: [createdPlugin, [updatedPlugin, pluginOptions]],
};

VS

// recommended
exports.mongoose = {
  client: {
    url: 'mongodb://127.0.0.1/example',
    options: {},
    // mongoose global plugins, expected a function or an array of function and options
    plugins: [createdPlugin, [updatedPlugin, pluginOptions]],
  },
};

atian25 · 2019-07-17T06:27:10Z

need unittest

JayJay1024 · 2019-07-17T11:25:16Z

unittest

这个测试就只能是把config.default.js改了

JasinYip · 2019-08-01T12:47:48Z

lib/mongoose.js

@@ -9,7 +9,7 @@ const filterURLPassword = require('./filterURLPassword');
 let count = 0;

 module.exports = app => {
-  const { client, clients, url, options, defaultDB, customPromise, loadModel, plugins } = app.config.mongoose;
+  let { client, clients, url, options, defaultDB, customPromise, loadModel, plugins } = app.config.mongoose;


不应该为了其中一个常量变成变量，就把所有常量都改为 let 哦

说的是👍

fixed: global plugins in app.config.mongoose.client

6abb3c7

atian25 requested a review from JasinYip July 17, 2019 06:27

JasinYip requested changes Aug 1, 2019

View reviewed changes

atian25 changed the title ~~fixed: global plugins in app.config.mongoose.client~~ fixe: global plugins in app.config.mongoose.client Aug 8, 2019

atian25 changed the title ~~fixe: global plugins in app.config.mongoose.client~~ fix: global plugins in app.config.mongoose.client Aug 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: global plugins in app.config.mongoose.client #39

fix: global plugins in app.config.mongoose.client #39

JayJay1024 commented Jul 16, 2019 •

edited

atian25 commented Jul 17, 2019

JayJay1024 commented Jul 17, 2019

JasinYip Aug 1, 2019

JayJay1024 Aug 2, 2019

fix: global plugins in app.config.mongoose.client #39

Are you sure you want to change the base?

fix: global plugins in app.config.mongoose.client #39

Conversation

JayJay1024 commented Jul 16, 2019 • edited

Checklist

Affected core subsystem(s)

Description of change

atian25 commented Jul 17, 2019

JayJay1024 commented Jul 17, 2019

JasinYip Aug 1, 2019

Choose a reason for hiding this comment

JayJay1024 Aug 2, 2019

Choose a reason for hiding this comment

JayJay1024 commented Jul 16, 2019 •

edited