Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Sequelize to config's declaration and test it works with sequelize-typescript #83

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jeff-Tian
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
  • index.d.ts 增加 Sequelize 字段以反映真实的设置,以及支持 TypeScript 里定制这个字段。
  • README.md 增加如何在 TypeScript 版 egg 项目里使用 sequelize-typescript 的说明。
  • test 目录下增加在 TypeScript 版 egg 项目里使用 sequelize-typescript 的测试用例。
  • README.md 增加如何在本地运行此项目的单元测试的说明。
  • 增加test.sh 以方便本地单元测试。

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #83 (8a3c1f4) into master (f585da5) will decrease coverage by 1.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   85.71%   84.37%   -1.34%     
==========================================
  Files           4        4              
  Lines          63       64       +1     
==========================================
  Hits           54       54              
- Misses          9       10       +1     
Impacted Files Coverage Δ
lib/loader.js 83.05% <100.00%> (-1.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a126c2b...a9f7d6e. Read the comment docs.

@Jeff-Tian
Copy link
Contributor Author

第一个提交测试通过,第二个提交没有本质改动,测试败在 npminstall 这一步。我在 fork 的 TravisCI 也重现了,清除 Cache 后,通过了。

@Jeff-Tian
Copy link
Contributor Author

@dead-horse @fengmk2 Any chance to get it approved and merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant