Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only set keep-alive header before Node.js 12.19.0 #4491

Closed
wants to merge 2 commits into from

Conversation

qingdengyue
Copy link
Contributor

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

only set keep-alive header before Node.js 12.19.0

@atian25
Copy link
Member

atian25 commented Oct 10, 2020

这样肯定不行啦,12 和 14 之间的就有问题了。

我指的是给 Node 12 那边提 PR

@qingdengyue
Copy link
Contributor Author

这样肯定不行啦,12 和 14 之间的就有问题了。

我指的是给 Node 12 那边提 PR

没太看懂啥意思?Node那边应该是因为12.19.0是LTS版本,所以合并了。

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #4491 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #4491   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           34        34           
  Lines         1113      1113           
  Branches       183       183           
=========================================
  Hits          1113      1113           
Impacted Files Coverage Δ
app/middleware/meta.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 773df78...756a90d. Read the comment docs.

@atian25
Copy link
Member

atian25 commented Oct 10, 2020

这样肯定不行啦,12 和 14 之间的就有问题了。
我指的是给 Node 12 那边提 PR

没太看懂啥意思?Node那边应该是因为12.19.0是LTS版本,所以合并了。

这个问题的最根本原因是, Node 那边没有判断 keep-alive 是否存在,重复设置了,所以应该是给 Node 那边提 PR 修复,你看我有提了一个到 Node 14 了。

你的意思是 Node 12 也 backport 了他们之前有问题的 PR,导致也出问题了?如果是的话,那可以去 backport 我的那个 PR 让 12 也不会重复设置。

@atian25
Copy link
Member

atian25 commented Oct 10, 2020

我看 CI 的 12 跑是没问题的,你确认最新的 Node 12 会导致重复设置?
https://github.com/eggjs/egg/actions/runs/298578308

@qingdengyue
Copy link
Contributor Author

我看 CI 的 12 跑是没问题的,你确认最新的 Node 12 会导致重复设置?
https://github.com/eggjs/egg/actions/runs/298578308

travis-ci上12会有重复设置的问题
https://www.travis-ci.org/github/VioletLife/egg/jobs/734478748

@atian25
Copy link
Member

atian25 commented Oct 10, 2020

好像是,那需要把那个 PR backport 给 Node 12

@atian25
Copy link
Member

atian25 commented Oct 10, 2020

nodejs/node#35138 这个

@rickyes
Copy link

rickyes commented Oct 10, 2020

@qingdengyue 可以把 nodejs/node#35138 backport 到 Node.js v12.x,按照这个文档来:https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md

@atian25
Copy link
Member

atian25 commented Oct 13, 2020

@rickyes nodejs/node#35623

@atian25
Copy link
Member

atian25 commented Oct 19, 2020

@qingdengyue https://github.com/eggjs/egg/pull/4497/files 要这样判断区间,而不是直接改

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants