Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig-paths #91

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

Karibash
Copy link
Contributor

close: #85

@codesandbox
Copy link

codesandbox bot commented Apr 10, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

🚮 Removed packages: tsconfig-paths@3.12.0

@psychobolt
Copy link

psychobolt commented May 3, 2023

This is needed to support projects using TypeScript 5.0 and using array extends in Storybook. storybookjs/storybook#21792

@naporin0624
Copy link

I ran into this problem in TS 5.0 when I used extends as an array. This fix is very important. I look forward to seeing it merged.

I have created a patch file that can be used with patch-package to address this issue.
https://gist.github.com/naporin0624/70c2e00f791d881895910a8f2cdb3026

@bastiankistner
Copy link

would be great if this could be merged! was just running into the extends is an array issue, which is a very helpful typescript feature

@adonaicandido
Copy link

Waiting on this as well. Storybook with TS 5.0 and Sveltekit depends on this.

@CloudBranch
Copy link

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Array

@lagunovsky
Copy link

As of March 2023, a good way to eliminate the NodeJS relative paths is to use the imports property in package.json. (In the codes below, #root is the project root.)

// package.json
{
  "imports": {
    "#root/*.js": "./*.js"
  }
}

// main.js:
const Source = require('#root/path/to/Source.js');

// Source.js:
module.exports = class Source {
  // ...
}

@prisis
Copy link

prisis commented Aug 29, 2023

Hey @egoist , do you have some time to take a look on this issue?

@anneau
Copy link

anneau commented Aug 31, 2023

Please merge this.

@ndelangen
Copy link

@egoist would you be able to look at merging this perhaps?

Storybook needs this to support newer TS5 features, see: storybookjs/storybook#21792

🙏🙏🙏

@unknownproperty
Copy link

+1 for storybook support

@egoist egoist merged commit 1085397 into egoist:dev Sep 14, 2023
2 checks passed
@prisis
Copy link

prisis commented Sep 14, 2023

Thank you @egoist ❤️

@egoist
Copy link
Owner

egoist commented Sep 14, 2023

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Karibash Karibash deleted the feature/update-tsconfig-paths branch September 14, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for jsconfig paths by bumping tsconfig-paths to 4.0