feat: add charset option (#267) (#330)

egoist · Apr 6, 2022 · d39fed7 · d39fed7
1 parent 875aed8
commit d39fed7
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 0 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -33,6 +33,7 @@ export type Options = {
   minifyWhitespace?: boolean
   minifyIdentifiers?: boolean
   minifySyntax?: boolean
+  charset?: CommonOptions['charset']
   keepNames?: boolean
   legalComments?: CommonOptions['legalComments']
   target?: string | string[]
@@ -180,6 +181,7 @@ export default (options: Options = {}): RollupPlugin => {
         sourcemap: sourceMap,
         sourcefile: id,
         pure: options.pure,
+        charset: options.charset,
         legalComments: options.legalComments,
       })
 

diff --git a/src/minify.ts b/src/minify.ts
@@ -19,6 +19,7 @@ export type Options = {
   minifyWhitespace?: boolean
   minifyIdentifiers?: boolean
   minifySyntax?: boolean
+  charset?: CommonOptions['charset']
   keepNames?: boolean
   legalComments?: CommonOptions['legalComments']
   target?: CommonOptions['target']
@@ -40,6 +41,7 @@ export const getRenderChunk = (options: Options): RenderChunkHook =>
         minifyWhitespace: options.minifyWhitespace,
         minifyIdentifiers: options.minifyIdentifiers,
         minifySyntax: options.minifySyntax,
+        charset: options.charset,
         keepNames: options.keepNames,
         legalComments: options.legalComments,
         sourcemap: options.sourceMap !== false,

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -101,6 +101,23 @@ describe('esbuild plugin', () => {
     `)
   })
 
+  test('charset', async () => {
+    const dir = realFs(getTestName(), {
+      './fixture/index.js': `
+        console.log('π')
+      `,
+    })
+    const output = await build({
+      dir,
+      rollupPlugins: [esbuild({ charset: 'utf8' })],
+      format: 'esm',
+    })
+    expect(output[0].code).toMatchInlineSnapshot(`
+      "console.log(\\"π\\");
+      "
+    `)
+  })
+
   test('keepNames', async () => {
     const dir = realFs(getTestName(), {
       './fixture/index.js': `