fix: make --treeshake work with hashbang

egoist · Aug 12, 2022 · c06b5e1 · c06b5e1
1 parent c3dc8d8
commit c06b5e1
Show file tree

Hide file tree

Showing 5 changed files with 50 additions and 22 deletions.
diff --git a/package.json b/package.json
@@ -65,7 +65,7 @@
     "tsconfig-paths": "3.12.0",
     "tsup": "6.0.1",
     "typescript": "4.6.3",
-    "vitest": "0.19.0",
+    "vitest": "0.21.1",
     "wait-for-expect": "3.0.2"
   },
   "peerDependencies": {

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/esbuild/index.ts b/src/esbuild/index.ts
@@ -103,8 +103,8 @@ export async function runEsbuild(
     format === 'iife'
       ? false
       : typeof options.splitting === 'boolean'
-        ? options.splitting
-        : format === 'esm'
+      ? options.splitting
+      : format === 'esm'
 
   const platform = options.platform || 'node'
   const loader = options.loader || {}
@@ -131,12 +131,12 @@ export async function runEsbuild(
     // esbuild's `external` option doesn't support RegExp
     // So here we use a custom plugin to implement it
     format !== 'iife' &&
-    externalPlugin({
-      external,
-      noExternal: options.noExternal,
-      skipNodeModulesBundle: options.skipNodeModulesBundle,
-      tsconfigResolvePaths: options.tsconfigResolvePaths,
-    }),
+      externalPlugin({
+        external,
+        noExternal: options.noExternal,
+        skipNodeModulesBundle: options.skipNodeModulesBundle,
+        tsconfigResolvePaths: options.tsconfigResolvePaths,
+      }),
     options.tsconfigDecoratorMetadata && swcPlugin({ logger }),
     nativeNodeModulesPlugin(),
     postcssPlugin({ css, inject: options.injectStyle }),
@@ -156,7 +156,8 @@ export async function runEsbuild(
   try {
     result = await esbuild({
       entryPoints: options.entry,
-      format: format === 'cjs' && splitting ? 'esm' : format,
+      format:
+        (format === 'cjs' && splitting) || options.treeshake ? 'esm' : format,
       bundle: typeof options.bundle === 'undefined' ? true : options.bundle,
       platform,
       globalName: options.globalName,
@@ -198,8 +199,8 @@ export async function runEsbuild(
         TSUP_FORMAT: JSON.stringify(format),
         ...(format === 'cjs' && injectShims
           ? {
-            'import.meta.url': 'importMetaUrl',
-          }
+              'import.meta.url': 'importMetaUrl',
+            }
           : {}),
         ...options.define,
         ...Object.keys(env).reduce((res, key) => {

diff --git a/src/plugins/tree-shaking.ts b/src/plugins/tree-shaking.ts
@@ -1,4 +1,5 @@
 import { rollup, TreeshakingOptions, TreeshakingPreset } from 'rollup'
+import hashbang from 'rollup-plugin-hashbang'
 import { Plugin } from '../plugin'
 
 export type TreeshakingStrategy =
@@ -20,6 +21,7 @@ export const treeShakingPlugin = ({
       const bundle = await rollup({
         input: [info.path],
         plugins: [
+          hashbang(),
           {
             name: 'tsup',
             resolveId(source) {

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -13,7 +13,10 @@ const cacheDir = path.resolve(__dirname, '.cache')
 const bin = path.resolve(__dirname, '../dist/cli-default.js')
 
 const getTestName = () => {
-  const name = expect.getState().currentTestName
+  const name = expect
+    .getState()
+    .currentTestName?.replace(/^[a-z]+/g, '_')
+    .replace(/-/g, '_')
 
   if (!name) {
     throw new Error('No test name')
@@ -944,7 +947,9 @@ test('use rollup for treeshaking', async () => {
     }
   )
   expect(await getFileContent('dist/input.mjs')).toContain(
-    `import { inject } from 'vue'`
+    `function useRoute() {
+  return inject(routeLocationKey);
+}`
   )
 })
 
@@ -1032,3 +1037,23 @@ test('remove unused code', async () => {
   )
   expect(await getFileContent('dist/input.js')).not.toContain('console.log(1)')
 })
+
+test('treeshake should work with hashbang', async () => {
+  const { getFileContent } = await run(
+    getTestName(),
+    {
+      'input.ts': '#!/usr/bin/node\nconsole.log(123)',
+    },
+    {
+      flags: ['--treeshake'],
+    }
+  )
+  expect(await getFileContent('dist/input.js')).toMatchInlineSnapshot(`
+    "#!/usr/bin/node
+    'use strict';
+
+    // input.ts
+    console.log(123);
+    "
+  `)
+})