- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support typescript 5.0 new syntax #859
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
"vitest": "0.28.4", | ||
"wait-for-expect": "3.0.2" | ||
}, | ||
"peerDependencies": { | ||
"@swc/core": "^1", | ||
"postcss": "^8.4.12", | ||
"typescript": "^4.1.0" | ||
"typescript": ">=4.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this not be something more like ^4.1.0 || ^5.0.0
since a newer version could break this again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in typescript, new minor versions, i.e 4.2 to 4.3 have the same potential breaking changes than major versions, in fact TS 5.0 does not break tsup at all if you don't use some of the new features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunately true (see microsoft/TypeScript#14116). If TypeScript followed semantic versioning, we would have major version bumps every single release. It is likely that we'd be at TypeScript 50+ by now! To Ryan Cavanaugh, the frequent major version bumps of TypeScript hence effectively render the semver scheme meaningless.
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds support for TS 5.0's new syntax, part of #858
This PR doesn't add support for mentioning multiple files in
extends
, so #849 wouldn't get fixed by thisTesting
gets converted to
with the following
d.ts
:export type *
also works but it added a lot of types that would make this section harder to read