Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support typescript 5.0 new syntax #859

Merged
merged 1 commit into from Mar 19, 2023
Merged

feat: support typescript 5.0 new syntax #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Expand Up @@ -59,22 +59,22 @@
"postcss-simple-vars": "6.0.3",
"prettier": "2.5.1",
"resolve": "1.20.0",
"rollup-plugin-dts": "5.2.0",
"rollup-plugin-dts": "5.3.0",
"rollup-plugin-hashbang": "2.2.2",
"strip-json-comments": "4.0.0",
"svelte": "3.46.4",
"terser": "^5.16.0",
"ts-essentials": "9.1.2",
"tsconfig-paths": "3.12.0",
"tsup": "6.6.1",
"typescript": "4.9.5",
"typescript": "5.0.2",
"vitest": "0.28.4",
"wait-for-expect": "3.0.2"
},
"peerDependencies": {
"@swc/core": "^1",
"postcss": "^8.4.12",
"typescript": "^4.1.0"
"typescript": ">=4.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be something more like ^4.1.0 || ^5.0.0 since a newer version could break this again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in typescript, new minor versions, i.e 4.2 to 4.3 have the same potential breaking changes than major versions, in fact TS 5.0 does not break tsup at all if you don't use some of the new features

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately true (see microsoft/TypeScript#14116). If TypeScript followed semantic versioning, we would have major version bumps every single release. It is likely that we'd be at TypeScript 50+ by now! To Ryan Cavanaugh, the frequent major version bumps of TypeScript hence effectively render the semver scheme meaningless.

},
"peerDependenciesMeta": {
"typescript": {
Expand Down
40 changes: 20 additions & 20 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.