Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcemaps break when using treeshake: 'smallest' #889

Open
aleclarson opened this issue Apr 21, 2023 · 2 comments · May be fixed by #890
Open

Sourcemaps break when using treeshake: 'smallest' #889

aleclarson opened this issue Apr 21, 2023 · 2 comments · May be fixed by #890

Comments

@aleclarson
Copy link

aleclarson commented Apr 21, 2023 •
edited by polar-sh bot

It seems when Rollup is used for extra tree-shaking, the sourcemaps no longer trace back to correct positions in the source code. This makes breakpoints effectively useless.

You might be forgetting to feed the sourcemaps into Rollup?

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
aleclarson added a commit to aleclarson/tsup that referenced this issue Apr 21, 2023
@aleclarson
fix: pass sourcemap into Rollup treeShakingPlugin
7a745b7 
Fixes egoist#889
@aleclarson aleclarson linked a pull request Apr 21, 2023 that will close this issue
Open
aleclarson added a commit to alloc/alien-dom that referenced this issue Apr 21, 2023
@aleclarson
chore(build): use treeshake=smallest in production only
ed699eb 
It breaks the sourcemaps.

See egoist/tsup#889
aleclarson added a commit to alloc/alien-dom that referenced this issue Apr 21, 2023
@aleclarson
chore(build): use treeshake=smallest in production only
dc291a3 
It breaks the sourcemaps.

See egoist/tsup#889
@xia0hj
Copy link

xia0hj commented Dec 28, 2023

I met this problem too, it might be caused by incorrect use of applySourceMap here

tsup/src/plugin.ts

Lines 156 to 166 in 322cb77

if (result.map) {
const originalConsumer = await new SourceMapConsumer(
parseSourceMap(info.map)
)
const newConsumer = await new SourceMapConsumer(
parseSourceMap(result.map)
)
const generator =
SourceMapGenerator.fromSourceMap(originalConsumer)
generator.applySourceMap(newConsumer, info.path)
info.map = generator.toJSON()

correct example: https://github.com/mozilla/source-map/blob/master/test/test-source-map-generator.js#L356-L362

Besides, default output is ./dist/index.js.map. But rollup treeshake sourcemap path is ./out.js.map, result in incorrect sources path src/index.ts. The correct one should be ../src/index.ts

I fixed these 2 bugs in #1069

@xia0hj xia0hj mentioned this issue Dec 28, 2023
Open
@aleclarson
Copy link
Author

aleclarson commented Dec 28, 2023 •
edited

In addition to @xia0hj's PR, there's also this one: #949 (by @hyrious)

I've not tested it myself. Interestingly, it's quite a bit different than @xia0hj's solution.

@rygine rygine mentioned this issue Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass sourcemap into Rollup treeShakingPlugin aleclarson/tsup
2 participants
@aleclarson @xia0hj