Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect sourcemap with --treeshake #1069

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Conversation

xia0hj
Copy link

@xia0hj xia0hj commented Dec 28, 2023

depends on pr #890

related to issue #889 (comment)

  1. fix incorrect use of applySourceMap()
    correct example: https://github.com/mozilla/source-map/blob/master/test/test-source-map-generator.js#L356-L362

  2. set rollup treeshake output path to ./dist, so that sources in sourcemap can refer to ../src/index.ts instead of src/index.ts

Copy link

codesandbox bot commented Dec 28, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tsup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 3:38pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant