Add onDTSSuccess option

[NickBolles]

Fixes #700

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tsup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 17, 2023 3:54am

[toteto]

Personally would expect the fix and desired behavior to be onSuccess to be called once the command (build+dts) has completed. I think there is very little use of having callback for success DTS separate from the build success callback.

In addition to this there is no guarantee that DTS will finish after the builds

tsup/src/index.ts

Line 408 in 690af7b

await Promise.all([dtsTask(), mainTasks()])

This makes it quite unreliable even so simple cases like "copy all files when the whole build step is completed"

[NickBolles]

@toteto i think my comment on the linked fixed issue is a pretty compelling use case:

We're using onsuccess to call yalc publish for a dev command. We see the JS code get updated in the consuming app, but not the typings until the next build. calling onSuccess again when dts is complete, or having another handler for dts completion would be helpful for this usecase too.
#700 (comment)

maybe this pr doesnt completely fix #700 though because there are other use cases