fix: outExtension for generating dts files by rollup #1053
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
outExtension
for generated dts files? #939Description:
Rollup operates in a Node.js Worker threads and can only receive messages as plain objects (without functions). In
tsup.config
, outExtension is a function. Therefore if we send the config "as is", we encounter a DataCloneError.Solution:
Execute
outExtension
before sending message to rollup worker thread and send the array withoutExtension
results.