feat(minor): use shell option for complex commands in onSuccess #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jgoux
commented
Jun 8, 2022
| const args = parts.splice(1) | ||
| existingOnSuccess = execa(exec, args, { | ||
| existingOnSuccess = execa(options.onSuccess, { | ||
| shell: true, |
There was a problem hiding this comment.
This is the interesting change. 😄
jgoux
changed the title
egoist
changed the title
|
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I activated the
shelloption for executing commands passed toonSuccess. It allows for more complicated commands and workflows.A very concrete use-case is to reboot a web server after the build is done:
{ "scripts": { "dev": "tsup src/index.ts --format esm,cjs --clean --watch src --onSuccess 'pnpm build:types && kill-port 4000 && pnpm start'", "build": "tsup src/index.ts --format esm,cjs --clean --onSuccess 'pnpm build:types'", "build:types": "tsc --project tsconfig.build.json --emitDeclarationOnly --declaration --declarationMap", "start": "node ./dist/index.js", } }Sorry for the code format changes but it seems like prettier wasn't run on dev?