Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TypeScript declarations #2

Closed
wants to merge 0 commits into from
Closed

Conversation

vatson
Copy link

@vatson vatson commented Jul 16, 2018

Recently, TS is becoming more popular. It would be great if you allow to add support for TypeScript.

types/index.d.ts Outdated Show resolved Hide resolved
@vatson
Copy link
Author

vatson commented Nov 12, 2018

@egoist I added prop types, pls check

@phildebr
Copy link

Could you please merge this?

@mnapoli
Copy link

mnapoli commented Apr 12, 2020

Would be great to have!

Edit: I can confirm that this works.

@rbclark
Copy link

rbclark commented Sep 29, 2020

Unsure if this is still up-to-date but came to this repo explicitly looking for typings for this package, would really be great to see this merged.

@Shinigami92
Copy link

Unsure if this is still up-to-date but came to this repo explicitly looking for typings for this package, would really be great to see this merged.

Same

types/index.d.ts Outdated
Comment on lines 2 to 3
import { FunctionalComponentOptions } from 'vue';
const _default: FunctionalComponentOptions<{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { FunctionalComponentOptions } from 'vue';
const _default: FunctionalComponentOptions<{
import { FunctionalComponent } from 'vue';
const _default: FunctionalComponent<{

types/index.d.ts Outdated
Comment on lines 4 to 5
code: string;
language: string;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
code: string;
language: string;
code?: string;
language?: string;

@elevatebart
Copy link

If this PR is only missing the changes suggested, can @vatson make them so we can merge?
@egoist, @Shinigami92 what are your suggestions?

I could also fork @vatson repo, do the changes, and create a new PR.

@elevatebart
Copy link

This closes #39

@Shinigami92
Copy link

@vatson What's the status of this? Why just closed?

@vatson
Copy link
Author

vatson commented Aug 13, 2021

@vatson What's the status of this? Why just closed?

@Shinigami92

First, the PR has been stuck for 3 years. I don't see any interest and activity from the maintainer side. All of this tells me that this issue will be here forever.

Second, current master branch is far ahead. It's has already been migrated on vue 3. It makes incompatible code with proposed typings.

I could do typings for both vue 2 and vue 3 with new PRs, but still I'm not sure if the project maintainers are ready to assist and support. It looks like a waste of time to me.

@Shinigami92
Copy link

@vatson In such a case, did you consider https://github.com/DefinitelyTyped/DefinitelyTyped ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants