fix: change response code to bad request for unconfigured hostname #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being the internet, folks who probe the server with an invalid hostname shouldn't raise 500 error alarms in monitoring.
|
👍 This makes sense as having this be a |
leftieFriele
approved these changes
Apr 4, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
## [1.3.45](v1.3.44...v1.3.45) (2024-05-13) ### Bug Fixes * change response code to bad request for unconfigured hostname ([#401](#401)) ([babc560](babc560))
|
🎉 This PR is included in version 1.3.45 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being the internet, folks who probe the server with an invalid Host header shouldn't raise 500 error alarms in monitoring.