Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config as param #484

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Config as param #484

wants to merge 2 commits into from

Conversation

trygvea
Copy link

@trygvea trygvea commented Jun 5, 2023

Currently, @eik/service is responsible for loading the configuration. We need more flexibility for implementations of this service to add its own config, or having separate configs for different environments/hosts etc.

This is a proposal for sending config as constructor param to EikService, using JSDoc to describe the config. Old convict defaults is preserved.

This PR introduces a BREAKING_CHANGE.

Trygve Amundsen added 2 commits June 5, 2023 16:37
BREAKING_CHANGE: receive config in Service constructor in stead of reading it
from config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant