Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to packaging #338

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Switch to packaging #338

merged 4 commits into from
Oct 5, 2023

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Jul 11, 2023

This PR

  • switches from the deprecated pkg_resources to packaging (Fixes Replace setuptools runtime dependency with packaging #337)
  • changes CI so it actually installs runtime dependencies specified in the package metadata’s install_requires (instead of manually specifying setuptools)
  • adds a pyproject.toml for a standards based build (instead of legacy convention based)

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Aug 18, 2023

FYI, you can change the workflow approval setting from

Fork pull request workflows from outside collaborators

  • Require approval for first-time contributors who are new to GitHub
  • Require approval for first-time contributors

to

Fork pull request workflows from outside collaborators

  • Require approval for first-time contributors who are new to GitHub
  • Require approval for first-time contributors

see https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories

@kmsquire
Copy link

kmsquire commented Oct 3, 2023

Bump. It would be nice to get this in!

@askpatrickw
Copy link

Unfortunately, since this merge the GH Actions have been failing.
https://github.com/ekalinin/nodeenv/actions

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Nov 16, 2023

Seems like linting failures, should be easily fixable:

nodeenv.py:421:19: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
setup.py:16:1: E402 module level import not at top of file

No idea why I didn’t see those while authoring this PR.

/edit: ah, it’s because they didn’t exist when I wrote this PR. See #347 (comment)

pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
@rschwebel rschwebel mentioned this pull request Dec 19, 2023
@flying-sheep flying-sheep mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace setuptools runtime dependency with packaging
5 participants