Changed the error to more understandable when the region code isn't set

eksctl-io · Feb 2, 2024 · 634321b · 634321b
1 parent b39bb66
commit 634321b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/pkg/eks/api.go b/pkg/eks/api.go
@@ -187,6 +187,9 @@ func newAWSProvider(spec *api.ProviderConfig, configurationLoader AWSConfigurati
 	}
 
 	if spec.Region == "" {
+		if cfg.Region == "" {
+			return nil, fmt.Errorf("no region code: please set the AWS region to ~/.aws/config file or environment variables")
+		}
 		spec.Region = cfg.Region
 	}
 

diff --git a/pkg/eks/api_test.go b/pkg/eks/api_test.go
@@ -118,6 +118,14 @@ var _ = Describe("eksctl API", func() {
 			},
 			err: fmt.Sprintf("cache file %s is not private", cacheFilePath),
 		}),
+		Entry("region code is not set", newAWSProviderEntry{
+			updateFakes: func(fal *fakes.FakeAWSConfigurationLoader) {
+				fal.LoadDefaultConfigReturns(aws.Config{
+					Region: "",
+				}, nil)
+			},
+			err: fmt.Sprintf("no region code: please set the AWS region to ~/.aws/config file or environment variables"),
+		}),
 		Entry("creates the AWS provider successfully", newAWSProviderEntry{}),
 	)