Split tags2entity #4203
Open
Split tags2entity #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arcel-split-tags2entity # Conflicts: # src/sql/schema112.sql
…arcel-split-tags2entity # Conflicts: # src/classes/Update.php # src/models/AbstractEntity.php # src/models/Tags.php # src/models/TeamTags.php # src/models/Templates.php # src/sql/schema113.sql # src/templates/edit.html # src/templates/templates-edit.html # src/templates/view.html
src/models/Items.php
Outdated
| @@ -114,6 +114,7 @@ public function duplicate(): int | |||
| 'canread' => $this->entityData['canread'], | |||
| 'canwrite' => $this->entityData['canwrite'], | |||
| 'canbook' => $this->entityData['canbook'], | |||
| // TODO: check why category_id is not always present | |||
There was a problem hiding this comment.
category_id has been removed because it is now the same as category
MarcelBolten
commented
Sep 29, 2023
src/sql/schema129.sql
Outdated
| FROM tags2entity WHERE item_type LIKE 'items'; | ||
|
|
||
| -- create tags2items_types | ||
| CREATE TABLE `tags2items_types` ( |
There was a problem hiding this comment.
@NicolasCARPi
Do we need this table? Seems like there is no possibility in the web front end to add tags to resource templates.
…arcel-split-tags2entity # Conflicts: # src/Make/MakeEln.php # src/models/AbstractEntity.php # src/models/Tags.php # src/models/TeamTags.php # src/sql/schema129-down.sql # src/sql/schema129.sql # src/templates/field-builder-modal.html # src/templates/show.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4146