Some changes to the new request actions #5088
Open
+235
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* catch timeout error
* add types * avoid removal of particular user action from all entities
MarcelBolten
force-pushed
the
marcel-request-actions
branch
from
224a41b
to
4e30f64
Compare
NicolasCARPi
requested changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed and merged after #5086 and #5087.
requester_useridandtarget_useridso they can be linked touseridadd a timeout (15 min) to avoid that the same action can be requested over and over again from the same user for a particular target user. Maybe the actual timeout could be a (sys)admin setting?don't let users request the same action multiple times