Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the line-height property in reset.css #77

Closed
wants to merge 1 commit into from

Conversation

CHRIBUR0309
Copy link

@CHRIBUR0309 CHRIBUR0309 commented Sep 5, 2023

Added the line-height property to the resetter to withstand any future specification changes that might be made to the browser's useragent style sheet.

@fabulousgk
Copy link
Contributor

Why? How does this change perform a reset? Seems like an opinionated format to me.

@elektronik2k5
Copy link
Contributor

Why? How does this change perform a reset? Seems like an opinionated format to me.

I agree. @CHRIBUR0309 please explain why and how is line-height different from all the other properties to justify such an exception.

@oinochoe
Copy link
Contributor

oinochoe commented Sep 9, 2023

I agree with them. I'm curious if there are any benefits to altering the userAgent style. Also, using the asterisk seems to be not a good method.

@QINGCHARLES
Copy link

This is crazy just dropping this pull request with zero citations to any articles which discuss this issue. I have no idea what this change is supposed to do or why it is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants