Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry metrics exporter #1407

Merged
merged 22 commits into from
Apr 5, 2023
Merged

OpenTelemetry metrics exporter #1407

merged 22 commits into from
Apr 5, 2023

Conversation

dmathieu
Copy link
Member

This PR is setting up an OpenTelemetry metrics exporter, based on the specification in elastic/apm#742.

@apmmachine
Copy link
Collaborator

apmmachine commented Mar 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-04-03T08:42:52.678+0000

  • Duration: 3 min 18 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dmathieu
Copy link
Member Author

dmathieu commented Mar 31, 2023

Re: CI test failures on Go 1.15, 1.16 and 1.17.
Supporting Go versions down to 1.15 with OpenTelemetry is going to be very tricky.

Otel follows the Golang release policy:

Each major Go release is supported until there are two newer major releases.

Which means it only support 1.19 and 1.20, and has therefore started using generics, making it impossible to use this version with any Go < 1.18.
Going to a lower version of the SDK will not be possible either, as the metrics API wasn't finalized back then.

module/apmotel/gatherer.go Outdated Show resolved Hide resolved
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a couple of comments.

module/apmotel/config.go Show resolved Hide resolved
module/apmotel/gatherer.go Show resolved Hide resolved
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
Signed-off-by: dmathieu <damien.mathieu@elastic.co>
@dmathieu dmathieu marked this pull request as ready for review April 3, 2023 12:54
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmathieu great work, thank you. We just need to update the module major version suffixes, otherwise this is good to merge.

We can update the code later based on the outcome of the spec discussion about default bounds.

module/apmotel/gatherer.go Outdated Show resolved Hide resolved
module/apmotel/go.mod Outdated Show resolved Hide resolved
module/apmotel/config.go Outdated Show resolved Hide resolved
module/apmotel/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmathieu dmathieu merged commit 641f68c into elastic:main Apr 5, 2023
11 checks passed
@dmathieu dmathieu deleted the apmotel branch April 5, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants