Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scala Future test case using multiple threads #1918

Closed
wants to merge 10 commits into from

Conversation

milanvdm
Copy link
Contributor

@milanvdm milanvdm commented Jul 13, 2021

Related to #1274

The main issue was related to scala/bug#12089 which got introduced in Scala 2.13.0.

From what I can tell, #1274 added a new test case that actually deadlocks on 2.13.0-2.13.3. This causes some weird behavior in the new test case.

After upgrading to 2.13.6 and using the ExecutionContext.global instead of a custom ForkJoinPool, the test case passes.

I also added extra test cases with different ExecutionContexts and different approaches on ending transactions.

@henrikno

@apmmachine
Copy link
Collaborator

apmmachine commented Jul 13, 2021

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: The PR is not allowed to run in the CI yet

  • Start Time: 2021-12-08T12:39:44.209+0000

  • Duration: 4 min 19 sec

  • Commit: 7df14f6

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run compatibility tests : Run the JDK Compatibility test.

  • run integration tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@SylvainJuge SylvainJuge added the community Issues and PRs created by the community label Jul 27, 2021
@AlexanderWert AlexanderWert moved this from In Progress to Planned in APM-Agents (OLD) Aug 23, 2021
@milanvdm
Copy link
Contributor Author

milanvdm commented Oct 2, 2021

Could someone have another look at this or will this wait until there is a decision on how to support community plugins?

@AlexanderWert AlexanderWert removed this from Planned in APM-Agents (OLD) Oct 18, 2021
@milanvdm
Copy link
Contributor Author

@felixbarny Any progress on this? :)

@SylvainJuge SylvainJuge added the size:small Small (S) tasks label Jan 31, 2022
@botelastic
Copy link

botelastic bot commented Apr 1, 2022

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as stalled to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the stalled label Apr 1, 2022
@botelastic
Copy link

botelastic bot commented Apr 15, 2022

Hi! This issue has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this issue if you think it should stay open. Thank you for your contribution!

@botelastic botelastic bot closed this Apr 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2022

@botelastic[bot] is not allowed to run commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-java community Issues and PRs created by the community size:small Small (S) tasks stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants