Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add section about unhandled rejections in config docs #3323

Merged
merged 2 commits into from May 8, 2023

Conversation

david-luna
Copy link
Member

@david-luna david-luna commented May 5, 2023

Description

Unhandled rejections are captured by the agent in NodeJS v15+ environments but there was no mention of it in the docs.

Fixes #2366

Checklist

  • Implement code
  • Add tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label May 5, 2023
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) May 5, 2023
@david-luna david-luna requested a review from trentm May 5, 2023 14:24
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo.

docs/configuration.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: Trent Mick <trent.mick@elastic.co>
@david-luna david-luna merged commit 67f02aa into main May 8, 2023
3 checks passed
APM-Agents (OLD) automation moved this from In Progress to Done May 8, 2023
@david-luna david-luna deleted the dluna/2366-unahndledRejection-docs branch May 8, 2023 10:05
trentm added a commit that referenced this pull request May 16, 2023
* docs: add section about unhandled rejections in config docs


Co-authored-by: Trent Mick <trent.mick@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
Development

Successfully merging this pull request may close these issues.

capture an error for unhandledRejection
2 participants