Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: saucelabs firefox update #1303

Merged
merged 1 commit into from
Nov 3, 2022
Merged

chore: saucelabs firefox update #1303

merged 1 commit into from
Nov 3, 2022

Conversation

devcorpio
Copy link
Contributor

Context

The apm-rum-vue e2e tests were failing because of the following combination:

Mozilla recently removed the ability to pass the capability --remote-debugging-port in Firefox GeckoDriver version 0.31.0.

and

On October 4, 2022, Sauce Labs updated the supported Firefox GeckoDriver to version 0.31.0 for tests on Firefox versions 90 and later. If you use the –remote-debugging-port capability, your tests will fail if you do not take action before October 4, 2022.

More info here

Fix

The cleanest fix for this would be to update to a new version of karma-sauce-launcher. Unfortunately, a new version available with the updated webdriverio dependency is not yet available.

The solution proposed by saucelabs is to set the geckodriverVersion config option to 0.30.0. This is the solution that we have applied.

Once the new version of karma-sauce-launcher is available we will update it and remove the 0.30.0 config option.

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Is it worth updating saucelabs version as well?

Copy link
Member

@kyungeunni kyungeunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apmmachine
Copy link
Collaborator

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 66.0 KiB 21.0 KiB 💚 0 Bytes
elastic-apm-rum.umd.min.js 59.9 KiB 19.5 KiB 💚 0 Bytes

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-03T16:04:26.673+0000

  • Duration: 99 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 4740
Skipped 64
Total 4804

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 98.077% (51/52)
Classes 98.077% (51/52)
Methods 97.519% (393/403)
Lines 95.284% (2061/2163)
Conditionals 86.352% (1025/1187)

@devcorpio
Copy link
Contributor Author

This PR has been created in karma-sauce-launcher repo

LGTM, Is it worth updating saucelabs version as well?

We will update this on the issue where we will update all our dependencies. It's going to be fun 😄

@devcorpio devcorpio merged commit ecde399 into elastic:main Nov 3, 2022
@devcorpio devcorpio deleted the sauce_labs_firefox_fix branch November 3, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants