Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace bundlesize with bundlesize2 #1306

Merged
merged 1 commit into from
Nov 7, 2022
Merged

chore: replace bundlesize with bundlesize2 #1306

merged 1 commit into from
Nov 7, 2022

Conversation

devcorpio
Copy link
Contributor

@devcorpio devcorpio commented Nov 7, 2022

Summary

bundlesize depends on a version of brotli that depends on iltorb 2.4.5 which is an archived repo and it's failing with Node.js 14

This change is recommended by the author of bundlesize.

@apmmachine
Copy link
Collaborator

apmmachine commented Nov 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-07T12:21:11.063+0000

  • Duration: 72 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 4740
Skipped 64
Total 4804

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 66.0 KiB 21.0 KiB 💚 0 Bytes
elastic-apm-rum.umd.min.js 59.9 KiB 19.5 KiB 💚 0 Bytes

@apmmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 98.148% (53/54)
Classes 98.148% (53/54)
Methods 97.406% (413/424)
Lines 95.26% (2110/2215)
Conditionals 86.278% (1050/1217)

Copy link
Member

@kyungeunni kyungeunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@devcorpio devcorpio merged commit 21b4071 into elastic:main Nov 7, 2022
@devcorpio devcorpio deleted the bundlesize-update branch November 7, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants