feat(rum-core): add fallback to click transaction name #1452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a scenario in findCustomTransactionName, where it returns
null
if it doesn't find a closest element matching theINTERACTIVE_SELECTOR
. In our frontend, we utilize clickable elements like images that are not wrapped inbutton
ora
tags, but they do have thedata-transaction-name
attribute defined. However, the current implementation still leads to aClick - img
transaction name.I noticed the current behavior is covered in unit tests which suggests it might be by design? If not, then I'm proposing a slight modification to the
findCustomTransactionName
function to returntarget.dataset.transactionName
as a fallback when no closest matching element is found.Looking forward to your feedback. Thank you!