Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to remove a workaround recommendation #8005

Merged
merged 2 commits into from May 6, 2022
Merged

Conversation

michaelhyatt
Copy link
Contributor

Motivation/summary

v0.24 of lambda layer introduced a fix that doesn't require the workaround mentioned.

The Otel AWS Lambda Node.js instrumentation documentation contains a workaround specifying OTEL_EXPORTER_OTLP_ENDPOINT waiting for open-telemetry/opentelemetry-js#2331 to be merged.

Now that the above PR was merged, the workaround is no longer required.

Checklist

Related issues

open-telemetry/opentelemetry-js#2331

v0.24 of lambda layer introduced a fix that doesn't require the workaround mentioned.
@mergify
Copy link
Contributor

mergify bot commented Apr 29, 2022

This pull request does not have a backport label. Could you fix it @michaelhyatt? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Apr 29, 2022
@apmmachine
Copy link
Collaborator

apmmachine commented Apr 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-06T13:47:53.053+0000

  • Duration: 36 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 3981
Skipped 13
Total 3994

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /hey-apm : Run the hey-apm benchmark.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

apmmachine commented Apr 29, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (43/43) 💚
Files 91.919% (182/198) 👍
Classes 93.421% (426/456) 👍
Methods 89.3% (1085/1215) 👍
Lines 76.825% (13167/17139) 👍 0.017
Conditionals 100.0% (0/0) 💚

@simitt simitt enabled auto-merge (squash) May 6, 2022 13:47
@simitt simitt merged commit 9513674 into main May 6, 2022
@simitt simitt deleted the michaelhyatt-patch-2 branch May 6, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify test-plan-skip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants