Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError when NodePool._dead_nodes timestamps are not unique #115

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix TypeError when NodePool._dead_nodes timestamps are not unique #115

merged 1 commit into from
May 28, 2024

Conversation

floxay
Copy link
Contributor

@floxay floxay commented Sep 10, 2023

Makes node objects comparable by overriding the < operator on the BaseNode class.

Fixes #114

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 10, 2023 •
edited

💚 CLA has been signed

@floxay floxay changed the title Implement __lt__() for BaseNode Fix TypeError when some timestamps of items in NodePool._dead_nodes are not unique Sep 10, 2023
@pquentin
Copy link
Member

Hello, closing for now as you haven't signed the CLA, sorry. Feel free to reopen when you have.

@pquentin pquentin closed this Jan 18, 2024
@floxay
Copy link
Contributor Author

floxay commented Jan 18, 2024 •
edited

Hey, I tried to sign it before but it looks like something went wrong.
Is there an issue if I sign it using the Github generated email I used to commit the changes with?

Edit: Nevermind, it looks like it worked now, however I am unable to reopen.

@pquentin pquentin reopened this Jan 18, 2024
@pquentin
Copy link
Member

Thanks! Reopened.

@floxay floxay force-pushed the 114-fix-node-in-PriorityQueue branch from fcf9d04 to 04b51d7 Compare January 25, 2024 18:07
pquentin
pquentin approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin changed the title Fix TypeError when some timestamps of items in NodePool._dead_nodes are not unique Fix TypeError when NodePool._dead_nodes timestamps are not unique May 28, 2024
@pquentin pquentin added Category: Bug Something isn't working backport 8.13 Area: Client Manually written code that fits in no other area backport 8.14 labels May 28, 2024
@pquentin pquentin merged commit 61a56cd into elastic:main May 28, 2024
14 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@floxay @github-actions
Implement __lt__() for BaseNode (#115)
c52e0af 
(cherry picked from commit 61a56cd)
@github-actions github-actions bot mentioned this pull request May 28, 2024
Merged
github-actions bot pushed a commit that referenced this pull request May 28, 2024
@floxay @github-actions
Implement __lt__() for BaseNode (#115)
f37f021 
(cherry picked from commit 61a56cd)
@github-actions github-actions bot mentioned this pull request May 28, 2024
Merged
pquentin pushed a commit that referenced this pull request May 28, 2024
@github-actions @floxay
Implement __lt__() for BaseNode (#115) (#170)
138ab84 
(cherry picked from commit 61a56cd)

Co-authored-by: Huba Tuba <57007485+floxay@users.noreply.github.com>
pquentin pushed a commit that referenced this pull request May 28, 2024
@github-actions @floxay
Implement __lt__() for BaseNode (#115) (#171)
137ac38 
(cherry picked from commit 61a56cd)

Co-authored-by: Huba Tuba <57007485+floxay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
Area: Client Manually written code that fits in no other area backport 8.13 backport 8.14 Category: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception on NodePool._dead_nodes
2 participants
@floxay @pquentin